Skip to content

sound: extend CI checks #14

Open
mewmew wants to merge 12 commits into
zikichombo:masterfrom
mewpull:ci
Open

sound: extend CI checks #14
mewmew wants to merge 12 commits into
zikichombo:masterfrom
mewpull:ci

Conversation

@mewmew

@mewmew mewmew commented Sep 7, 2018

Copy link
Copy Markdown
Member

Add GolangCI meta linter among others.

Code coverage token will be added in a follow-up PR.

@wsc1

wsc1 commented Sep 7, 2018

Copy link
Copy Markdown
Member

I added ci_checks.sh to meta

@wsc1

wsc1 commented Sep 7, 2018

Copy link
Copy Markdown
Member

LGTM

@wsc1 wsc1 closed this Sep 7, 2018
@wsc1 wsc1 reopened this Sep 7, 2018
@wsc1

wsc1 commented Sep 7, 2018

Copy link
Copy Markdown
Member

sorry, didn't mean to close

@wsc1 wsc1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why revert ci_checks script?

@mewmew

mewmew commented Sep 7, 2018

Copy link
Copy Markdown
Member Author

why?

I couldn't get code coverage reporting to work with the token you sent, so had to update and trouble shoot the ci_checks script. And I don't have access to zc/meta as far as I know.

@wsc1

wsc1 commented Sep 7, 2018

Copy link
Copy Markdown
Member

Github tells me you have admin access on all zc repos.

@mewmew

mewmew commented Sep 7, 2018

Copy link
Copy Markdown
Member Author

Oh well, we can live without code coverage reporting for now. I tried to trouble shoot why the COVERALLS_TOKEN is not set by travis, but couldn't figure it out. Without this token, this branch is never taken:

if [ "${COVERALLS_TOKEN}" ]; then
	echo "### go tool cover"
	go test -covermode=count -coverprofile=coverage.out ./...
	go tool cover -func coverage.out

	# To submit the test coverage result to coveralls.io use goveralls
	# (https://github.com/mattn/goveralls)
	goveralls -coverprofile coverage.out -service travis-ci -repotoken ${COVERALLS_TOKEN}
fi

@mewmew

mewmew commented Sep 7, 2018

Copy link
Copy Markdown
Member Author

Github tells me you have admin access on all zc repos.

Oh, that's more than I know. I thought I was only part of ext.

@mewmew

mewmew commented Sep 7, 2018

Copy link
Copy Markdown
Member Author

Feel free to merge this and then the COVERALLS_TOKEN issue can be trouble shot later.

got to go.

Cheers,
/u

@wsc1

wsc1 commented Sep 8, 2018

Copy link
Copy Markdown
Member

Since we've got so many CI build issues, maybe I'll clean up the various more cosmetic issues from these new CI checks in the repo first...

@wsc1

wsc1 commented Sep 8, 2018

Copy link
Copy Markdown
Member

Looking more closely, it seems the linter is checking whether error return values are checked?

I don't like that; for example, when using sndbuf there are no io errors but it has them to fit the interface. Is there some way to refine the linter checks or the files on which they operate? Don't want to lose a badge over something like that :(

@wsc1

wsc1 commented Sep 27, 2018

Copy link
Copy Markdown
Member

any ideas on how to make travis recognise stdatomic.h via cgo?

@mewmew

mewmew commented Sep 27, 2018

Copy link
Copy Markdown
Member Author

It should work with newer versions of GCC, as suggested in cmus/cmus#604

If there is something specific to Cgo that prevents it from working, I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants